Set a maximum number of accepted deadline miss the the AdvanceableRunner #726
Conversation
|
A test is failing Maybe due to #724 ? 🤔 @traversaro |
|
|
||
| // we have to close the runner | ||
| this->m_isRunning = false; | ||
| break; |
There was a problem hiding this comment.
This is done only when telemetry is enabled, is this intentional? Or perhaps know that deadlineMiss is used for something else we should change the logic?
There was a problem hiding this comment.
This is done only when telemetry is enabled, is this intentional
Before I used it just to print some info at the end of the application but probably now it's better to keep this always active. What do you think?
There was a problem hiding this comment.
In 5b6d71c I removed the possibility to disable the telemetry so the check will be always active
Yes, it seems it was failing also there #724 . |
Fixed by #727 . |
As per the title, this PR adds the possibility to stop the advanceable runner if the number of deadline misses exceeds the accepted maximum